Linux/linux e3b8b6akernel/sched core.c

sched/core: Fix compilation error when cgroup not selected

When cgroup is disabled the following compilation error was hit

        kernel/sched/core.c: In function ‘uclamp_update_active_tasks’:
        kernel/sched/core.c:1081:23: error: storage size of ‘it’ isn’t known
          struct css_task_iter it;
                               ^~
        kernel/sched/core.c:1084:2: error: implicit declaration of function ‘css_task_iter_start’; did you mean ‘__sg_page_iter_start’? [-Werror=implicit-function-declaration]
          css_task_iter_start(css, 0, &it);
          ^~~~~~~~~~~~~~~~~~~
          __sg_page_iter_start
        kernel/sched/core.c:1085:14: error: implicit declaration of function ‘css_task_iter_next’; did you mean ‘__sg_page_iter_next’? [-Werror=implicit-function-declaration]
          while ((p = css_task_iter_next(&it))) {
                      ^~~~~~~~~~~~~~~~~~
                      __sg_page_iter_next
        kernel/sched/core.c:1091:2: error: implicit declaration of function ‘css_task_iter_end’; did you mean ‘get_task_cred’? [-Werror=implicit-function-declaration]
          css_task_iter_end(&it);
          ^~~~~~~~~~~~~~~~~
          get_task_cred
        kernel/sched/core.c:1081:23: warning: unused variable ‘it’ [-Wunused-variable]
          struct css_task_iter it;
                               ^~
        cc1: some warnings being treated as errors
        make[2]: *** [kernel/sched/core.o] Error 1

Fix by protetion uclamp_update_active_tasks() with
CONFIG_UCLAMP_TASK_GROUP

Fixes: babbe170e053 ("sched/uclamp: Update CPU's refcount on TG's clamp changes")
Reported-by: Randy Dunlap <rdunlap at infradead.org>
Signed-off-by: Qais Yousef <qais.yousef at arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz at infradead.org>
Tested-by: Randy Dunlap <rdunlap at infradead.org>
Cc: Steven Rostedt <rostedt at goodmis.org>
Cc: Ingo Molnar <mingo at redhat.com>
Cc: Vincent Guittot <vincent.guittot at linaro.org>
Cc: Patrick Bellasi <patrick.bellasi at matbug.net>
Cc: Mel Gorman <mgorman at suse.de>
Cc: Dietmar Eggemann <dietmar.eggemann at arm.com>
Cc: Juri Lelli <juri.lelli at redhat.com>
Cc: Ben Segall <bsegall at google.com>
Link: https://lkml.kernel.org/r/20191105112212.596-1-qais.yousef@arm.com
DeltaFile
+1-1kernel/sched/core.c
+1-11 files

UnifiedSplitRaw