Illumos/gate 44bf619usr/src/cmd/svc/startd graph.c restarter.c, usr/src/cmd/ul Makefile

10703 smatch unreachable code checking needs reworking
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate a99cb96usr/src Makefile.master, usr/src/tools/make Makefile.com

11531 tools/make should set NATIVE_CCFLAGS
Reviewed by: Aurélien Larcher  <aurelien.larcher at gmail.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 7e6ac63usr/src/uts/i86pc/dboot dboot_startkern.c dboot_elfload.c

11539 dboot: build errors with gcc9
Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 889229busr/src/man/man2 fork.2

4705 fork(2): See "MT-Level of Libraries"
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate a3bfe1dusr/src/man/man9s ddi_device_acc_attr.9s

11497 ddi_device_acc_attr(9S) has the wrong version number
Reviewed by: Gergő Doma <domag02 at gmail.com>
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 634942fusr/src/man/man3 Intro.3

11582 3SCF isn't the object-caching memory allocation library
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 356ba08usr/src/cmd/make/bin main.cc, usr/src/cmd/make/include/mksh misc.h

11533 tools/make: gcc9 build errors
11534 tools/make: remove sys_nerr
11535 tools/make: amd64 arch is not supported
11536 tools/make: getmem() should take size_t
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 21c878fusr/src/uts/common/fs/zfs vdev.c

11559 zfs: device removal should not block bootability
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 6af2358usr/src/uts/common/fs/zfs vdev_disk.c

10623 ZFS should be more aggressive in updating vdev devid
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Gordon Ross <gwr at nexenta.com>
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 0f2f3e9usr/src/boot Makefile.version, usr/src/boot/sys/boot/efi/libefi efipart.c

11517 loader.efi: efipart should be more careful about constructing block device lists
Reviewed by: Joshua M. Clulow <josh at sysmgr.org>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate a9370e9usr/src/lib/libsecdb policy.conf, usr/src/man/man4 policy.conf.4

9096 passwords (policy.conf) should default to sha512
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate f67950busr/src/cmd/zfs zfs_main.c zfs_project.c, usr/src/man/man1m zfs.1m

11479 zfs project support
Portions contributed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Portions contributed by: Jinshan Xiong <jinshan.xiong at intel.com>
Portions contributed by: Suman Chakravartula <schakrava at gmail.com>
Portions contributed by: jxiong <jinshan.xiong at gmail.com>
Reviewed by: Brian Behlendorf <behlendorf1 at llnl.gov>
Reviewed by: Andreas Dilger <andreas.dilger at intel.com>
Reviewed by  Ned Bass <bass6 at llnl.gov>
Reviewed by: Matthew Ahrens <mahrens at delphix.com>
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Kody Kantor <kody.kantor at joyent.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate a2f0435usr/src/cmd/connstat connstat_main.c connstat_tcp.c, usr/src/man/man1m connstat.1m

11547 Want connstat(1M) command to display per-connection TCP statistics
Portions contributed by: Cody Peter Mello <cody.mello at joyent.com>
Portions contributed by: Ahmed G <ahmedg at delphix.com>
Reviewed by: Jason King <jason.king at joyent.com>
Reviewed by: Robert Mustacchi <rm at joyent.com>
Reviewed by: Dan McDonald <danmcd at joyent.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate c12492cusr/src/uts/common/inet tcp_impl.h, usr/src/uts/common/inet/tcp tcp_input.c tcp_output.c

11546 Track TCP round-trip time in nanoseconds
Portions contributed by: Cody Peter Mello <cody.mello at joyent.com>
Portions contributed by: Brandon Baker <bbaker at delphix.com>
Reviewed by: Jason King <jason.king at joyent.com>
Reviewed by: Robert Mustacchi <rm at joyent.com>
Reviewed by: Dan McDonald <danmcd at joyent.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate 519cca7usr/src/lib/libofmt/common ofmt.c ofmt.h, usr/src/man/man3ofmt ofmt.3ofmt Makefile

11545 Want configurable output field separator for libofmt
Portions contributed by: Cody Peter Mello <cody.mello at joyent.com>
Reviewed by: Jason King <jason.king at joyent.com>
Reviewed by: Robert Mustacchi <rm at joyent.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate 5b6e8d4usr/src/man/man3ofmt ofmt.3ofmt

11544 ofmt(3OFMT) should talk about the callback handler
Reviewed by: Dan McDonald <danmcd at joyent.com>
Reviewed by: Jason King <jason.brian.king at gmail.com>
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate e7a617ausr/src/uts/common/io/pciex pcieb_ioctl.h

11373 pcieb should enable link bandwidth notifications (add missing file)
Approved by: Joshua M. Clulow <josh at sysmgr.org>

Illumos/gate 20513f9usr/src/uts/common/io/pciex pcie_fault.c pciev.c, usr/src/uts/common/sys pcie_impl.h

11366 disappearing ixgbe turns correctable error into panic
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Reviewed by: Robert Mustacchi <rm at joyent.com>
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Paul Winder <Paul.Winder at wdc.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate 33756aeusr/src/uts/common/io/pciex pcie.c, usr/src/uts/common/sys pcie.h pcie_impl.h

11370 Update PCIe capability headers for PCIe 4.x
11371 Record PCIe gen 4 caps
Reviewed by: Mike Zeller <mike.zeller at joyent.com>
Reviewed by: Dan McDonald <danmcd at joyent.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Paul Winder <Paul.Winder at wdc.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate 662dc8ausr/src/uts/common/io/pciex pcie.c, usr/src/uts/common/sys pcie_impl.h pcie.h

11367 Capture PCI Express width and speed
Reviewed by: Dan McDonald <danmcd at joyent.com>
Reviewed by: Hans Rosenfeld <hans.rosenfeld at joyent.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Paul Winder <Paul.Winder at wdc.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate b3d69c0usr/src/cmd/pcieb pcieb.c, usr/src/lib/fm/topo/modules/common/pcibus did_props.c

11376 PCIe speeds and feeds should be exposed to userland
11373 pcieb should enable link bandwidth notifications
11374 Clean up pcieb CERRWARN and smatch
11375 Clean up pcie module -Wno-uninitialized and -Wno-parentheses
Reviewed by: Hans Rosenfeld <hans.rosenfeld at joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney at joyent.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Paul Winder <Paul.Winder at wdc.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate 79bed77usr/src/uts/common/io/pciex pcie_fault.c pcie.c, usr/src/uts/common/sys pcie_impl.h

11369 PCIe errors on passthru devices shouldn't cause a panic
Reviewed by: Robert Mustacchi <rm at joyent.com>
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney at joyent.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate e386d4dusr/src/cmd/mdb/common/modules/genunix pci.c devinfo.c

11372 Want PCIe dcmds and walkers
Reviewed by: Jon Anderson <jon.anderson at joyent.com>
Reviewed by: Rob Johnston <rob.johnston at joyent.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Paul Winder <Paul.Winder at wdc.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate 9b3f4feusr/src/uts/common/io/pciex pcie.c, usr/src/uts/common/sys pcie.h pcie_impl.h

11368 pcie changes for bhyve ppt
Reviewed by: Patrick Mooney <patrick.mooney at joyent.com>
Reviewed by: Mike Gerdts <mike.gerdts at joyent.com>
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Norm Jacobs <naj at snapcon.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate 4c63bf6usr/src/lib/libzfs/common libzfs_pool.c

11558 libzfs: allow device removal feature for root pool
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 4c52839usr/src/boot/lib/libstand printf.c

11565 loader: this statement may fall through
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 05876afusr/src/common/bzip2 bzlib.c

11566 bzip2: unused parameter 'opaque'
Reviewed by: Robert Mustacchi <rm at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate db8c8c3usr/src/boot/sys/boot/libficl Makefile.com

11567 loader: ficl vm.o volatile argument warning
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 2052a1fusr/src/boot/sys/boot/i386/libi386 pxe.c

11568 loader: pxe.c missing initializer
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Rob Johnston <rob.johnston at joyent.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 8d94f65usr/src/uts/common/fs/smbsrv smb2_durable.c smb_tree.c

11031 SMB3 persistent handles
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Reviewed by: Roman Strashkin <roman.strashkin at nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Joyce McIntosh <joyce.mcintosh at nexenta.com>
Reviewed by: Jason King <jason.king at joyent.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 2f57b5eusr/src Makefile.master

11532 Makefile.master: add gcc9 support flags
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Reviewed by: Alexander Pyhalov <apyhalov at gmail.com>
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate f8296c6usr/src/uts/common/io/vioblk vioblk.c, usr/src/uts/common/io/vioif vioif.c vioif.h

11329 improved Virtio framework
10012 vioblk should not accept an all-zero serial number
7366 vioif happily creates rx descriptors until it consumes all memory
Reviewed by: Robert Mustacchi <rm at joyent.com>
Approved by: Richard Lowe <richlowe at richlowe.net>

Illumos/gate d3b5f56usr/src Makefile.noget Makefile.master, usr/src/cmd/zlogin Makefile

11528 Makefile.noget can get gone
11529 Use -Wno-maybe-initialized
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate c4ccc1fusr/src/cmd/picl/plugins/sun4u/snowbird/frutree piclfrutree.c, usr/src/cmd/picl/plugins/sun4u/snowbird/lib/fruaccess libfruaccess.c

11226 Remove NetraCT support
Reviewed by: Gergő Doma <domag02 at gmail.com>
Reviewed by: Gordon Ross <gwr at nexenta.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate dcfeff9usr/src/boot/sys/boot/efi/loader/arch/amd64 ldscript.amd64

11561 loader script needs to place .eh_frame after .text
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate a8ffe49usr/src/boot Makefile.version, usr/src/boot/sys/boot/i386/gptzfsboot zfsboot.c

11555 gptzfsboot: boot prompt is not refreshed on device change
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 79940ffusr/src/uts/common/inet/ip ip_attr.c

11556 ip_attr.c functions need to not dereference conn_ixa directly after lock drop
Reviewed by: Jason King <jbk at joyent.com>
Reviewed by: Mike Gerdts <mgerdts at joyent.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Gordon Ross <gwr at nexenta.com>

Illumos/gate fe94961usr/src/tools/scripts wsdiff.py

10540 wsdiff much slower under python3 than python2
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Richard Lowe <richlowe at richlowe.net>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate c1064fdusr/src/uts/common/fs/zfs vdev.c

11541 allocation_classes feature must be enabled to add log device
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Kody Kantor <kody.kantor at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate c023f65usr/src/boot Makefile.version, usr/src/boot/lib/libstand/zfs zfsimpl.c Makefile.inc

10166 loader: support com.delphix:removing
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 582237eusr/src/tools/smatch Makefile

11548 11506 breaks the SPARC build
Reviewed by: Igor Kozhukhov <igor at dilos.org>
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate c6dd35dusr/src/boot Makefile.version, usr/src/boot/sys/boot/efi/libefi efi_console.c

11549 loader: smatch error: efi_cons_cursor(): uninitialized symbol 'row' and 'col'
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate bf8d275usr/src/uts/common/io/ib/ibnex ibnex_ioctl.c ibnex.c

10721 ib: NULL pointer errors
Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
Reviewed by: Gordon Ross <gordon.ross at nexenta.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 8bb3e7eusr/src/cmd/praudit format.c main.c, usr/src/man/man1m praudit.1m

9830 praudit should be able to map users and groups correctly
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Reviewed by: Joshua M. Clulow <josh at sysmgr.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 7f3e7b1usr/src/uts/i86pc/dboot dboot_startkern.c

11523 i86pc: dboot_startkern.c:2046: error: comparison between pointer and integer
Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 4f7f1d0usr/src/boot Makefile.version, usr/src/boot/sys/boot/i386/gptzfsboot zfsboot.c

11475 gptzfsboot: update parsing the option switches
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate efe51d0usr/src/tools/smatch/src smatch_math.c smatch_kernel_user_data.c

11506 smatch resync
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate cc7e66eusr/src/boot/sys/boot/efi/loader/i386 Makefile, usr/src/boot/sys/boot/libstand/i386 Makefile

11537 loader: i386 build is missing -m32 sometimes
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Reviewed by: Aurélien Larcher  <aurelien.larcher at gmail.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Robert Mustacchi <rm at joyent.com>

Illumos/gate 4f7f6bausr/src/uts/common/fs/smbsrv smb_dfs.c

11030 SMB2 ioct dfs_get_referral returns wrong error
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 959eaf3usr/src/cmd/smbsrv/smbadm smbadm.c, usr/src/man/man1m smbadm.1m

11029 smbadm man page needs updating
Reviewed by: Dan Fields <dan.fields at nexenta.com>
Reviewed by: Matt Barden <matt.barden at nexenta.com>
Approved by: Garrett D'Amore <garrett at damore.org>