Illumos/gate d9172acusr/src/cmd/format label.c menu_command.c

12004 format: err_check is duplicate of efi_err_check
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>

Illumos/gate edbad4fusr/src/cmd/format modify_partition.c io.c

11997 format: cstyle cleanup
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 5ac07b1usr/src/boot/sys/boot/common multiboot.S mb_header.S, usr/src/boot/sys/boot/efi/loader efiserialio.c comconsole.c

12058 loader.efi: use libi386/comconsole with x86
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 4d7988dusr/src/cmd/mdb/common/modules/zfs zfs.c, usr/src/uts/common/fs/zfs btree.c range_tree.c

11971 Reduce loaded range tree memory usage
Portions contributed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Reviewed by: George Wilson <gwilson at delphix.com>
Reviewed by: Matt Ahrens <matt at delphix.com>
Reviewed by: Sebastien Roy seb at delphix.com
Reviewed by: Igor Kozhukhov <igor at dilos.org>
Reviewed by: Brian Behlendorf <behlendorf1 at llnl.gov>
Reviewed by: Kody Kantor <kody.kantor at joyent.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate bb4b7f4usr/src/boot Makefile.version, usr/src/boot/sys/boot/efi/libefi efi_console.c

12049 loader: ReadKeyStrokeEx may return partial keystrokes
Reviewed by: Randy Fishel <randyf at sibernet.com>
Reviewed by: John Levon <john.levon at joyent.com>
Reviewed by: C Fraire <cfraire at me.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 9d0a7dbusr/src/boot Makefile.version, usr/src/boot/sys/boot/efi/libefi efipart.c

12044 loader.efi: fix cd boot for cisco C220M3
Reviewed by: Matthias Scheler <mscheler at tintri.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: C Fraire <cfraire at me.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 500bef5usr/src/cmd/format menu_command.c

11994 format: fix print of accessible sectors, also print first and last usable sector
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate e57e118usr/src/uts/common/vm seg_kmem.c

12045 segkmem_page_create(): Fire Walk With Me
Reviewed by: Jason King <jason.brian.king at gmail.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>

Illumos/gate 99d3b4eusr/src/test/zfs-tests/tests/functional/cli_root/zfs_diff zfs_diff_encrypted.ksh, usr/src/uts/common/fs/zfs dmu_diff.c

11950 diff_cb() does not handle large dnodes
Portions contributed by: Jason King <jason.king at joyent.com>
Reviewed by: Brian Behlendorf <behlendorf1 at llnl.gov>
Reviewed by: Tom Caputi <tcaputi at datto.com>
Reviewed by: Ryan Moeller <ryan at ixsystems.com>
Reviewed by: Kody Kantor <kody.kantor at joyent.com>
Reviewed by: Matthias Scheler <mscheler at tintri.com>
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate c4fc965usr/src/lib/libshell/common/sh nvtree.c

11979 libshell: bitwise comparison always evaluates to false
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>

Illumos/gate e63ea1fusr/src/uts/common/os streamio.c

12043 Streams ioctl for _I_CMD within kernel causes EFAULT
Reviewed by: John Levon <john.levon at joyent.com>
Reviewed by: Jason King <jason.king at joyent.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>

Illumos/gate b8dc1b4usr/src/cmd/zfs zfs_main.c, usr/src/lib/libshare/common libshare.c libshare.h

11945 pool import performance regression due to repeated libshare initialization
Reviewed by: Sanjay Nadkarni <sanjay.nadkarni at nexenta.com>
Reviewed by: Evan Layton <evan.layton at nexenta.com>
Reviewed by: Dan McDonald <danmcd at joyent.com>
Reviewed by: Jason King <jason.brian.king at gmail.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 69d9b1cusr/src/lib/libproc/common Pzone.c

11984 libproc: passing argument 2 to restrict-qualified parameter aliases with argument 1
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate ec38b3fusr/src/uts/common/io/comstar/lu/stmf_sbd sbd_scsi.c

12036 iscsi: zpool create pool fails to create label
Reviewed by: Rick McNeal <rick.mcneal at nexenta.com>
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: John Levon <john.levon at joyent.com>
Reviewed by: Kody Kantor <kody.kantor at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate c54162eusr/src/boot Makefile.version, usr/src/boot/sys/boot/efi/include efidevp.h efilib.h

12018 loader.efi: efipart needs better support detecting nested partitions
Reviewed by: Matthias Scheler <mscheler at tintri.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>

Illumos/gate 4deedc8usr/src/uts/common/io tem_safe.c

12041 tem: x86 needs to use tems.ts_color_map() for 8-bit colors
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Alexander Eremin <a.eremin at nexenta.com>
Reviewed by: Randy Fishel <randyf at sibernet.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>

Illumos/gate 2f57294usr/src/boot/sys/boot/i386/libi386 vbe.c

12040 loader: vbe_print_mode() is missing newline
Reviewed by: Volker A. Brandt <vab at bb-c.de>
Reviewed by: Matthias Scheler <mscheler at tintri.com>
Reviewed by: Randy Fishel <randyf at sibernet.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>

Illumos/gate e15e891usr/src/data/ucode Makefile.links README.ucode, usr/src/data/ucode/intel 00050654-01 000A0660-80

12005 update to Intel microcode-20191115
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate f7db590usr/src/lib/libshare/nfs libshare_nfs.c, usr/src/man/man1m share_nfs.1m

2988 nfssrv: need ability to go to submounts for v3 and v2 protocols
Portions contributed by: Marcel Telka <marcel.telka at nexenta.com>
Portions contributed by: Jean McCormack <jean.mccormack at nexenta.com>
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Alek Pinchuk <alek.pinchuk at nexenta.com>
Reviewed by: Dan Fields <dan.fields at nexenta.com>
Reviewed by: Dan McDonald <danmcd at joyent.com>
Approved by: Garrett D'Amore <garrett at damore.org>

Illumos/gate 19687f0usr/src/uts/common/io/blkdev blkdev.c

12017 Assertion failure in kstat_waitq_to_runq from blkdev
Reviewed by: Igor Kozhukhov <igor at dilos.org>
Reviewed by: Matthias Scheler <mscheler at tintri.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate c5832a5usr/src/test/zfs-tests/tests/functional/mount umount_unlinked_drain.ksh umount_002.ksh, usr/src/uts/common/fs/zfs zfs_dir.c zfs_vfsops.c

12002 async unlinked drain
Portions contributed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Portions contributed by: Roman Strashkin <roman.strashkin at nexenta.com>
Portions contributed by: Saso Kiselkov <saso.kiselkov at nexenta.com>
Reviewed by: Jorgen Lundman <lundman at lundman.net>
Reviewed by: Tom Caputi <tcaputi at datto.com>
Reviewed by: Brian Behlendorf <behlendorf1 at llnl.gov>
Reviewed by: Matt Ahrens <mahrens at delphix.com>
Reviewed by: Paul Dagnelie <pcd at delphix.com>
Reviewed by: Sanjay Nadkarni <sanjay.nadkarni at nexenta.com>
Reviewed by: Josef 'Jeff' Sipek <josef.sipek at nexenta.com>
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Kody Kantor <kody.kantor at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate f52943ausr/src/boot/sys/boot Makefile.inc, usr/src/boot/sys/boot/i386/btx/btx Makefile

12016 Use of GNU ld should explicitly specify the required output format
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Matthias Scheler <matthias.scheler at wdc.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>

Illumos/gate a64e1e2usr/src/cmd/format modify_partition.c

11996 format: modify should not ask for GPT partition 7
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate d30992fusr/src/cmd/format modify_partition.c io.c

11995 format: efi usable size is missing 1 sector
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate a629dedusr/src/test/zfs-tests/tests/functional/cli_root/zfs_diff zfs_diff_types.ksh zfs_diff_timestamp.ksh

11962 Port ZoL zfs diff tests to illumos
Portions contributed by: Tony Hutter <hutter2 at llnl.gov>
Portions contributed by: Tom Caputi <tcaputi at datto.com>
Portions contributed by: Jason King <jason.king at joyent.com>
Reviewed by: Jerry Jelinek <jerry.jelinek at joyent.com>
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 32a71e4usr/src/cmd/format modify_partition.c label.c

11993 format: reserved partition size calculation should use sector size
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 32114f8usr/src/cmd/zdb zdb.c

12012 zdb: do not output binary org.illumos:checksum_salt on terminal
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Jason King <jason.brian.king at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 93d2b6fusr/src/boot/sys/boot/efi/libefi efipart.c

11938 loader.efi: HARDDRIVE_DEVICE_PATH may have subpaths
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Joshua M. Clulow <josh at sysmgr.org>

Illumos/gate 247e9a8usr/src/uts/common/io/blkdev blkdev.c

12009 Memory leaks in blkdev when blkdev device is detached
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Reviewed by: Igor Kozhukhov <igor at dilos.org>
Reviewed by: Randy Fishel <randyf at sibernet.com>
Reviewed by: Matthias Scheler <matthias.scheler at wdc.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate eb44bccusr/src/tools/smatch Makefile, usr/src/tools/smatch/src smatch_kernel_user_data.c check_arm64_tagged.c

12013 fix smatch build for GCC4
Reviewed by: Dan McDonald <danmcd at joyent.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>

Illumos/gate aefa9c8usr/src/uts/common/io/vioif vioif.c

12015 vioif with MSI-X not working on Google Compute Engine
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Rick McNeal <rick.mcneal at nexenta.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate c00b028usr/src/uts/common/io/virtio virtio_main.c virtio_impl.h

12014 virtio_init_complete() comment should describe interrupt type parameter
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate bb51a97usr/src/test/zfs-tests/tests/functional/cli_root/zfs_diff Makefile

12021 zfs_diff tests missing Makefile deps
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Kody Kantor <kody.kantor at joyent.com>
Reviewed by: Jason King <jason.king at joyent.com>
Reviewed by: Paul Winder <paul at winders.demon.co.uk>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate e233687usr/src/lib/fm/topo/libtopo/common topo_string.c topo_xml.c, usr/src/lib/fm/topo/modules/common/fac_prov_ipmi fac_prov_ipmi.c

11960 Add topo module and hdl api for freeing string array
Reviewed by: Jordan Hendricks <jordan.hendricks at joyent.com>
Reviewed by: Matthias Scheler <matthias.scheler at wdc.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>

Illumos/gate 05c00ecusr/src/man/man2 mmap.2

12010 extra whitespace in mmap(2)
Reviewed by: Dan McDonald <danmcd at joyent.com>
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+12-18usr/src/man/man2/mmap.2
+12-181 files

Illumos/gate d1f3e3cusr/src/uts/i86pc/io hpet_acpi.c, usr/src/uts/i86pc/io/apix apix.c

11798 apix: cast between incompatible function types
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 027bcc9usr/src/uts/common/vm seg_kmem.c, usr/src/uts/i86pc/io cbe.c

11797 i86pc: cast between incompatible function types
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 4d95620usr/src/uts/common/io/blkdev blkdev.c, usr/src/uts/common/io/nvme nvme.c nvme_var.h

11827 Increase concurrency through blkdev
11847 The nvme cmd completion queue is contentious
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Reviewed by: Hans Rosenfeld <rosenfeld at grumpf.hope-2000.org>
Reviewed by: Matthias Scheler <matthias.scheler at wdc.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate d158018usr/src/man/man9f kmem_alloc.9f, usr/src/uts/common/fs/nfs nfs_auth.c

11927 Log, or optionally panic, on zero-length kmem allocations
Reviewed by: Dan McDonald <danmcd at joyent.com>
Reviewed by: Jason King <jason.brian.king at gmail.com>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>

Illumos/gate e725342usr/src/test/util-tests/tests/make make_test.ksh

12007 make_test always returns non-zero
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate c85f09cusr/src/tools/smatch/src simplify.c lib.c

11972 resync smatch
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 3128654usr/src/boot Makefile.version, usr/src/boot/sys/boot/common tem.c

11973 tem: we only can translate colors 0-7
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Reviewed by: Garrett D'Amore <garrett at damore.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 62ce8e2usr/src/lib/libefi/common rdwr_efi.c mapfile-vers, usr/src/man/man3ext Makefile efi_alloc_and_init.3ext

12003 libefi: add efi_reserved_sectors()
Reviewed by: John Levon <john.levon at joyent.com>
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 78d8302usr/src/lib/libproc/common Psymtab.c

11986 libproc: cast between incompatible function types
Reviewed by: John Levon <john.levon at joyent.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 5928363usr/src/test/libc-tests/runfiles default.run

12008 libc symbol test timeout should be bumped
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Garrett D'Amore <garrett at damore.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>

Illumos/gate f557613usr/src/uts/common/os cpu_uarray.c

12001 cpu_uarray_free(NULL) panics
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Jason King <jason.brian.king at gmail.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 6b02bf3usr/src/cmd/boot/installboot/i386 installboot.c

11999 installboot: multiple stage1 locations are mismanaged
Reviewed by: Jason King <jason.king at joyent.com>
Reviewed by: Andy Fiddaman <omnios at citrus-it.co.uk>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate a8661d6usr/src/uts/common/fs/smbsrv smb2_create.c

11863 SMB2 CREATE should validate impersonation level
11864 SMB2 CREATE should reject absolute paths
11865 SMB2 CREATE should check MxAc create context size
Reviewed by: Gordon Ross <Gordon.W.Ross at gmail.com>
Reviewed by: Garrett D'Amore <gdamore at racktopsystems.com>
Approved by: Dan McDonald <danmcd at joyent.com>

Illumos/gate 77de87dusr/src/test/crypto-tests/tests/common testfuncs.c cryptotest_kcf.c, usr/src/test/crypto-tests/tests/modes/aes/ctr aes_ctr.c

11965 crypto tests only test multi-part operations a byte at a time
Reviewed by: Dan McDonald <danmcd at joyent.com>
Approved by: Gordon Ross <gordon.w.ross at gmail.com>

Illumos/gate 327d971usr/src/uts/common/io/idm idm_conn_sm.c

11791 idm: this statement may fall through
Reviewed by: Andy Fiddaman <andy at omniosce.org>
Reviewed by: Garrett D'Amore <garrett at damore.org>
Approved by: Dan McDonald <danmcd at joyent.com>