OPNSense/core 36496e0src/opnsense/mvc/app/config services_api.php, src/opnsense/mvc/app/library/OPNsense/Mvc Router.php Dispatcher.php

mvc - work in progress to replace Phalcon Application()

https://github.com/opnsense/core/issues/6389
DeltaFile
+172-0src/opnsense/mvc/app/library/OPNsense/Mvc/Router.php
+167-0src/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php
+131-0src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php
+0-127src/opnsense/mvc/app/config/services_api.php
+126-0src/opnsense/mvc/app/library/OPNsense/Mvc/Request.php
+116-0src/opnsense/mvc/app/library/OPNsense/Mvc/Response.php
+712-12712 files not shown
+1,160-20018 files

OPNSense/core 1c86776src/opnsense/scripts/firmware connection.sh

firmware: dump TLS infrmation for firmware server(s) in use

Will make it easier to identify proxy isses.
DeltaFile
+19-1src/opnsense/scripts/firmware/connection.sh
+19-11 files

OPNSense/core 6084f72src/opnsense/mvc/app/config services_api.php, src/opnsense/mvc/app/library/OPNsense/Mvc Router.php Dispatcher.php

mvc - work in progress to replace Phalcon Application()

https://github.com/opnsense/core/issues/6389
DeltaFile
+172-0src/opnsense/mvc/app/library/OPNsense/Mvc/Router.php
+167-0src/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php
+131-0src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php
+0-127src/opnsense/mvc/app/config/services_api.php
+126-0src/opnsense/mvc/app/library/OPNsense/Mvc/Request.php
+113-0src/opnsense/mvc/app/library/OPNsense/Mvc/Headers.php
+709-12711 files not shown
+1,154-17617 files

OPNSense/core 07bfc94src/opnsense/mvc/app/library/OPNsense/Mvc Router.php Dispatcher.php

mvc - work in progress to replace Phalcon Application()

https://github.com/opnsense/core/issues/6389
DeltaFile
+172-0src/opnsense/mvc/app/library/OPNsense/Mvc/Router.php
+167-0src/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php
+131-0src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php
+126-0src/opnsense/mvc/app/library/OPNsense/Mvc/Request.php
+113-0src/opnsense/mvc/app/library/OPNsense/Mvc/Headers.php
+110-0src/opnsense/mvc/app/library/OPNsense/Mvc/Response.php
+819-010 files not shown
+1,126-1016 files

OPNSense/core eecfa04src/opnsense/mvc/app/library/OPNsense/Mvc Router.php Dispatcher.php

mvc - work in progress to replace Phalcon Application()

https://github.com/opnsense/core/issues/6389
DeltaFile
+172-0src/opnsense/mvc/app/library/OPNsense/Mvc/Router.php
+164-0src/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php
+131-0src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php
+125-0src/opnsense/mvc/app/library/OPNsense/Mvc/Request.php
+113-0src/opnsense/mvc/app/library/OPNsense/Mvc/Headers.php
+110-0src/opnsense/mvc/app/library/OPNsense/Mvc/Response.php
+815-010 files not shown
+1,122-1016 files

OPNSense/core e0d4eecsrc/www interfaces.php

interfaces: for consistency

(cherry picked from commit 80284fb2811c8b8cfbb0fd01fba9b3d81238b642)
DeltaFile
+2-2src/www/interfaces.php
+2-21 files

OPNSense/core 80284fbsrc/www interfaces.php

interfaces: for consistency
DeltaFile
+2-2src/www/interfaces.php
+2-21 files

OPNSense/core 786cfa1src/www interfaces.php

Interfaces - change help text to reflect reality

PR: https://github.com/opnsense/core/issues/7339

(cherry picked from commit ff1991cdee25d86181276143f0b9abfb90963d68)
(cherry picked from commit e37514e6f6c0cdfc746ff044aeb567b527b71a0c)
DeltaFile
+8-8src/www/interfaces.php
+8-81 files

OPNSense/core e37514esrc/www interfaces.php

interfaces: tweak wording in interface gateway selection (#7445)

DeltaFile
+6-6src/www/interfaces.php
+6-61 files

OPNSense/core 1b4cb9fsrc/opnsense/mvc/app/controllers/OPNsense/Kea/forms dialogOption4.xml, src/opnsense/mvc/app/views/OPNsense/Kea dhcpv4.volt

Services: Kea DHCP: Kea DHCPv4 - rename code to dhcp option. (https://github.com/opnsense/core/pull/7361)
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/dialogOption4.xml
+1-1src/opnsense/mvc/app/views/OPNsense/Kea/dhcpv4.volt
+2-22 files

OPNSense/core 56b3a44. plist, src/opnsense/mvc/app/library/OPNsense/Core Csrf.php

legacy/csrf - move csrf check code from https://github.com/opnsense/core/commit/d1962f8ed5c5144b71ecda5ea0a21c0605b212fb into legacy scope.

The original intend was to be able to reuse the Csrf class, but as this requires direct access to the session object, it's likely not a good idea for the goals of https://github.com/opnsense/core/issues/6389
Since the legacy pages need a lock on session anyway,  keeping it doesn't make a difference.
DeltaFile
+0-58src/opnsense/mvc/app/library/OPNsense/Core/Csrf.php
+27-4src/www/csrf.inc
+0-1plist
+27-633 files

OPNSense/core 40b4e95src/www interfaces.php

interfaces: tweak wording in interface gateway selection
DeltaFile
+6-6src/www/interfaces.php
+6-61 files

OPNSense/core 5724385src/opnsense/scripts/system sysctl.py, src/opnsense/service/conf/actions.d actions_system.conf

system: allow (multiple) sysctl calls over configd

(cherry picked from commit 7f6f55814f0447162acdc431689d464ff2b06471)
(cherry picked from commit a36b700ec507cd959a7a791fad029c0852afc3ac)
DeltaFile
+51-34src/opnsense/scripts/system/sysctl.py
+8-2src/opnsense/service/conf/actions.d/actions_system.conf
+1-1src/www/system_advanced_sysctl.php
+60-373 files

OPNSense/core 24f36bfsrc/etc config.xml.sample, src/etc/inc system.inc

system: as a POC move this security setting to the automatic sysctls #7440

This might not work for all values as we would maybe like the have the
FreeBSD default itself to work its magic.  For security relevant things
bootstrapping the value is useful, but for buffer sizes it might not be.
DeltaFile
+0-9src/etc/config.xml.sample
+1-1src/etc/inc/system.inc
+1-102 files

OPNSense/core 93ecc7dsrc/opnsense/mvc/app/library/OPNsense/Mvc Router.php Dispatcher.php

mvc - work in progress to replace Phalcon Application()

https://github.com/opnsense/core/issues/6389
DeltaFile
+179-0src/opnsense/mvc/app/library/OPNsense/Mvc/Router.php
+158-0src/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php
+131-0src/opnsense/mvc/app/library/OPNsense/Mvc/Request.php
+113-0src/opnsense/mvc/app/library/OPNsense/Mvc/Headers.php
+109-0src/opnsense/mvc/app/library/OPNsense/Mvc/Response.php
+84-0src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php
+774-010 files not shown
+1,064-1016 files

OPNSense/core 84e2438src/opnsense/mvc/app/library/OPNsense/Mvc Router.php Dispatcher.php

mvc - work in progress to replace Phalcon Application()

https://github.com/opnsense/core/issues/6389
DeltaFile
+179-0src/opnsense/mvc/app/library/OPNsense/Mvc/Router.php
+158-0src/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php
+127-0src/opnsense/mvc/app/library/OPNsense/Mvc/Request.php
+113-0src/opnsense/mvc/app/library/OPNsense/Mvc/Headers.php
+103-0src/opnsense/mvc/app/library/OPNsense/Mvc/Response.php
+71-0src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php
+751-07 files not shown
+949-013 files

OPNSense/core 050068dsrc/opnsense/mvc/app/library/OPNsense/Mvc Router.php Dispatcher.php

mvc - work in progress to replace Phalcon Application()

https://github.com/opnsense/core/issues/6389
DeltaFile
+179-0src/opnsense/mvc/app/library/OPNsense/Mvc/Router.php
+158-0src/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php
+127-0src/opnsense/mvc/app/library/OPNsense/Mvc/Request.php
+113-0src/opnsense/mvc/app/library/OPNsense/Mvc/Headers.php
+103-0src/opnsense/mvc/app/library/OPNsense/Mvc/Response.php
+71-0src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php
+751-07 files not shown
+949-013 files

OPNSense/core c9d46d3src/opnsense/mvc/app/library/OPNsense/Mvc Router.php Dispatcher.php

mvc - work in progress to replace Phalcon Application()

https://github.com/opnsense/core/issues/6389
DeltaFile
+196-0src/opnsense/mvc/app/library/OPNsense/Mvc/Router.php
+158-0src/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php
+127-0src/opnsense/mvc/app/library/OPNsense/Mvc/Request.php
+113-0src/opnsense/mvc/app/library/OPNsense/Mvc/Headers.php
+103-0src/opnsense/mvc/app/library/OPNsense/Mvc/Response.php
+71-0src/opnsense/mvc/app/library/OPNsense/Mvc/Session.php
+768-07 files not shown
+966-013 files

OPNSense/core 294a043src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes NetworkAliasField.php

mvc/model - implement getDescription() in NetworkAliasField. As this field type acts as a single (non-list) type, we need to return the description from here as well as BaseListField's implementation doesn't apply here.

(cherry picked from commit 697992bb53c46e7f365a33e7a2fc271051f8e2ac)
DeltaFile
+12-0src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkAliasField.php
+12-01 files

OPNSense/core 747a2dfsrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes BaseListField.php

mvc/model - BaseListField replace array_map+strval for loop with cast to preserve execution time. The mapping with strval seems to be rather slow, a simple cast seems to be roughly 4 times faster.

(cherry picked from commit b139e33e4c9b00b35f8263b469ba2fe022d1e23e)
DeltaFile
+5-2src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseListField.php
+5-21 files

OPNSense/core 9190873src/opnsense/mvc/app/library/OPNsense/Base UIModelGrid.php, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes BaseListField.php ModelRelationField.php

mvc: refactor grid search to fetch descriptive values from the model instead of trying to reconstruct them.

PR: https://github.com/opnsense/core/issues/7383

(cherry picked from commit 10c81a4eea87a17a180ff93cc9c3aa2cc6d72d85)
(cherry picked from commit b36b8edf87393a00f60b0646cf78dda8ff026ed7)
(cherry picked from commit 966bda3c96d7e799334cd4b69bfa1b03c58023d9)
(cherry picked from commit c4b64a417d4d2c5f0f5a2fb121eac255a860dcb6)
(cherry picked from commit 353c89f5c0ec54cf3a4c753d8a07bde1f534d13d)
DeltaFile
+18-0src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseListField.php
+1-16src/opnsense/mvc/app/library/OPNsense/Base/UIModelGrid.php
+4-12src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php
+11-0src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+4-3src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ArrayField.php
+38-315 files

OPNSense/core 8cac182src/opnsense/mvc/app/models/OPNsense/Base BaseModel.php

mvc - change exception handling in runMigrations() to avoid mismatches in attributes being silently ignored.

When a migration tries to address an non existing attribute, a InvalidArgumentException is thrown, but only partially noted in the log.
It's likely safer to abort the migration if steps fail and send the error to the log for further inspection.

(cherry picked from commit 14ea1b96e8923ca0a571e73124930f86ecbd63ae)
DeltaFile
+5-2src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php
+5-21 files

OPNSense/core 3380ae4src/opnsense/mvc/app/models/OPNsense/Base BaseModel.php, src/opnsense/mvc/script run_migrations.php

mvc - extend model implementation to ease legacy migrations.

(cherry picked from commit 35b5e0b64bb01f892179d89704d60521eaf549d8)
(cherry picked from commit 637208acdba3bc60b02cc7f16a71459974b5e36e)
(cherry picked from commit e516ea7ec8418b3744c8b42ac552825c35a2eb96)
(cherry picked from commit 668a057dac4b154d9feedb6483dafdaf49096219)
DeltaFile
+95-38src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php
+4-0src/opnsense/mvc/script/run_migrations.php
+99-382 files

OPNSense/core e7f0488src/opnsense/mvc/app/controllers/OPNsense/Base ApiMutableModelControllerBase.php, src/opnsense/mvc/app/controllers/OPNsense/IDS/Api SettingsController.php

mvc - replace \Phalcon\Filter\Validation\Exception  with \OPNsense\Base\ValidationException (both simple empty Exception classes).

for https://github.com/opnsense/core/issues/6389

(cherry picked from commit 0dc6089f8a8766462e126d9b9f73d3ea42c9aab3)
DeltaFile
+35-0src/opnsense/mvc/app/models/OPNsense/Base/ValidationException.php
+17-17src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/SettingsController.php
+11-11src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api/SettingsController.php
+11-11src/opnsense/mvc/app/controllers/OPNsense/Monit/Api/SettingsController.php
+7-7src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/IPPortFieldTest.php
+7-7src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php
+88-5325 files not shown
+141-10531 files

OPNSense/core 54f8097src/opnsense/mvc/app/library/OPNsense/Backup GDrive.php

system: adjust log levels in google drive backup; closes #7427

(cherry picked from commit eea9c5c58e0205a366600ef43dc7446c1c9e89b5)
DeltaFile
+2-2src/opnsense/mvc/app/library/OPNsense/Backup/GDrive.php
+2-21 files

OPNSense/core 2aff42asrc/etc rc.newwanipv6

interfaces: evidence suggests + 2 is better than + 1 #7400

The + 1 was completely arbitrary to begin with (derived from
FreeBSD scripting), but if part of the system needs longer to
cope with tentative state then this would be an easy way to
make it more reliable.

If + 3 makes sense for the next person is something I want to
doubt, however.

Special thanks go to @Wireheadbe for pursuing and testing this.

(cherry picked from commit f2e60c18f66a4bcf712078ea718fdb6a95385f55)
DeltaFile
+1-1src/etc/rc.newwanipv6
+1-11 files

OPNSense/core c16ce91src/opnsense/mvc/app/models/OPNsense/Interfaces Vip.php

fix typo in message about "outboud nat rule" (#7429)

* fix typo in message about "outboud nat rule"

* Removed unused $unqiue_addrs (with typo)

* Restore and fix typo $unique_addrs

(cherry picked from commit 66c684b2c66d26000129bfb161c6cbafe4175dc8)
DeltaFile
+2-2src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.php
+2-21 files

OPNSense/core 5ae6a29src/opnsense/mvc/app/controllers/OPNsense/Kea/forms dialogSubnet4.xml, src/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv4.xml

fix: :bug: Update field separator for Kea DHCP Subnet Form and Model (#7418)

Co-authored-by: Katerina Ford <kford at madtechnicalsolutions.com>
(cherry picked from commit c1548926ad0bcf3ed0fb10e75c3437ffbb0d329b)
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+1-1src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/dialogSubnet4.xml
+2-22 files

OPNSense/core 0f2743bsrc/opnsense/mvc/app/models/OPNsense/IPsec Swanctl.xml

VPN: IPsec: Connections - allow the equal sign for identity parsing as specified in https://docs.strongswan.org/docs/5.9/config/identityParsing.html, closes https://github.com/opnsense/core/issues/7424

(cherry picked from commit 7d212f3e5d9eb2456acf2165987dd850cd78c710)
DeltaFile
+4-4src/opnsense/mvc/app/models/OPNsense/IPsec/Swanctl.xml
+4-41 files

OPNSense/core 85d7c56src/etc/inc system.inc

system: disable userspace core dumps by default

Was suggested by @lattera on 93e0d1474.

(cherry picked from commit 886ee0623b8cf1015b71ff5988432922b93c830b)
DeltaFile
+1-0src/etc/inc/system.inc
+1-01 files